Update the rules_nixpkgs guide #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benradf
approved these changes
Jun 19, 2024
avdv
reviewed
Jun 20, 2024
| echo "-L${pkgs.libiconv}/lib" >> $out/nix-support/cc-cflags | ||
| echo "-L${pkgs.darwin.libobjc}/lib" >> $out/nix-support/cc-cflags | ||
| echo "-resource-dir=${pkgs.stdenv.cc}/resource-root" >> $out/nix-support/cc-cflags | ||
| '' + pkgs.lib.optionalString (builtins.hasAttr "libcxxabi" pkgs.llvmPackages) '' | ||
| echo "-L${pkgs.llvmPackages.libcxxabi}/lib" >> $out/nix-support/cc-cflags |
aherrmann
force-pushed
the
update-guide
branch
4 times, most recently
from
771bc17
to
01aee9c
Compare
Bazel introduced the option `darwin_x86_64`.
|
The CI failures on MacOS were an instance bazelbuild/rules_cc#226. The logic to generate the toolchain constraints needed to be updated to capture the value For reference, the failure looked like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use a more recent nixpkgs revision, Bazel 7, and more recent rules_cc.