Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type to getDebugInfo #4411

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Oct 24, 2024

No description provided.

@fabpot
Copy link
Contributor

fabpot commented Oct 24, 2024

Thank you @ruudk.

@fabpot fabpot merged commit 868b429 into twigphp:3.x Oct 24, 2024
48 of 49 checks passed
@ruudk ruudk deleted the debug-info-return-type branch October 24, 2024 11:52
@stof
Copy link
Member

stof commented Oct 25, 2024

this should not be necessary though, as the compiled template overrides an existing abstract method of the Template, where we already define the phpdoc type.

@ruudk
Copy link
Contributor Author

ruudk commented Oct 25, 2024

You are right. Sorry about this. We can revert this.

fabpot added a commit that referenced this pull request Oct 25, 2024
This reverts commit 868b429, reversing
changes made to b0017ad.
@fabpot
Copy link
Contributor

fabpot commented Oct 25, 2024

Reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants