Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models: Implement stage channels #793

Merged
merged 2 commits into from
Apr 22, 2021
Merged

models: Implement stage channels #793

merged 2 commits into from
Apr 22, 2021

Conversation

james7132
Copy link
Contributor

@james7132 james7132 commented Apr 22, 2021

As seen in: discord/discord-api-docs#2751.

  • Added GuildChannel::Stage variant, containing a VoiceChannel.
  • Added REQUEST_TO_SPEAK permission.
  • Added optional request_to_speak_timestamp to VoiceState
  • Unrelated: Added missing USE_SLASH_COMMANDS permission.

@james7132 james7132 added c-model Affects the model crate d-api Change related to Discord's API. labels Apr 22, 2021
@james7132 james7132 linked an issue Apr 22, 2021 that may be closed by this pull request
3 tasks
Copy link
Member

@zeylahellyer zeylahellyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change should be in a separate PR, otherwise lgtm

model/src/guild/permissions.rs Outdated Show resolved Hide resolved
@zeylahellyer zeylahellyer added the t-feature Addition of a new feature label Apr 22, 2021
Copy link
Contributor

@7596ff 7596ff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@7596ff 7596ff merged commit 57e054c into twilight-rs:trunk Apr 22, 2021
@zeylahellyer zeylahellyer mentioned this pull request Apr 22, 2021
3 tasks
zeylahellyer added a commit that referenced this pull request Apr 27, 2021
Additions

Support the `MemberUpdate::{deaf, mute}` fields ([#774] - [@7596ff]).

Support guild stage channels, add `REQUEST_TO_SPEAK` permission
([#793] - [@james7132]).

Support the `USE_SLASH_COMMANDS` permission ([#794] - [@james7132]).

[@7596ff]: https://github.com/7596ff
[@james7132]: https://github.com/james7132
[#794]: #794
[#793]: #793
[#774]: #774

Signed-off-by: Vivian Hellyer <[email protected]>
zeylahellyer added a commit that referenced this pull request Apr 27, 2021
Additions

Support the `MemberUpdate::{deaf, mute}` fields ([#774] - [@7596ff]).

Support guild stage channels ([#793] - [@james7132]).

[@7596ff]: https://github.com/7596ff
[@james7132]: https://github.com/james7132
[#793]: #793
[#774]: #774

Signed-off-by: Vivian Hellyer <[email protected]>
@zeylahellyer zeylahellyer added the f-stage-instances Related to supporting the Stage Instances feature. label May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-model Affects the model crate d-api Change related to Discord's API. f-stage-instances Related to supporting the Stage Instances feature. t-feature Addition of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement stage channels
3 participants