-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(combobox): prevent selection of disabled items #3260
Conversation
Run & review this pull request in StackBlitz Codeflow. |
🦋 Changeset detectedLatest commit: 30c21cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 30c21cc:
|
Passing run #6056 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Size Change: +26 B (0%) Total Size: 995 kB
ℹ️ View Unchanged
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 30c21cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this require any changes when Downshift releases the functionality?
Not necessarily, but it may be an opportunity to simplify our code if/when we upgrade |
This PR fixes the issue where disabled items in Combobox could still be selected if using keyboard navigation.
Newer versions of Downshift will allow this more easily, but the fix isn't released yet. The idea for this approach comes from one of their issue topics.