Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chatlog): fix overflow on message bubbles #3723

Merged
merged 2 commits into from
Jan 26, 2024
Merged

fix(chatlog): fix overflow on message bubbles #3723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72a3818
fix(chatlog): fix overflow on message bubbles
TheSisb Jan 16, 2024
6bd30d5
chore: add story example that covers a very long, wrapping word
TheSisb Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/pink-buckets-hope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@twilio-paste/chat-log": patch
"@twilio-paste/core": patch
---

[ChatLog] Fix overflow on message bubbles
3 changes: 3 additions & 0 deletions packages/paste-core/components/chat-log/src/ChatBubble.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ export const ChatBubble = React.forwardRef<HTMLDivElement, ChatBubbleProps>(
paddingY="space30"
paddingX="space40"
marginBottom="space30"
wordWrap="break-word"
maxWidth="100%"
minWidth={0}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: it might be useful to have a vrt example to cover this usecase.

element={element}
ref={ref}
variant={variant}
Expand Down
4 changes: 3 additions & 1 deletion packages/paste-core/components/chat-log/stories/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,9 @@ export const ExampleChatLog: StoryFn = () => (
</ChatMessageMeta>
</ChatMessage>
<ChatMessage variant="outbound">
<ChatBubble>Nulla sit amet elit mauris.</ChatBubble>
<ChatBubble>
https://www.LONGURLTEST.LONGURLTEST.LONGURLTEST.LONGURLTEST.LONGURLTEST.LONGURLTEST.LONGURLTEST.LONGURLTEST.LONGURLTEST.LONGURLTEST.LONGURLTEST.LONGURLTEST.LONGURLTEST.LONGURLTEST.com
</ChatBubble>
<ChatMessageMeta aria-label="said by you at 4:32pm">
<ChatMessageMetaItem>4:32pm</ChatMessageMetaItem>
</ChatMessageMeta>
Expand Down
Loading