fix(nx): remove access token. Sets via env variables #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
dosubot
bot
added
the
size:XS
github-actions
bot
added
the
Status: Do Not Merge
krisantrobus
added
the
🕵🏻♀️ Run website visual regression
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c52240f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c52240f:
|
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
github-actions
bot
added
the
Area: Infrastructure
|
Size Change: 0 B Total Size: 1.09 MB ℹ️ View Unchanged
|
krisantrobus
commented
Aug 21, 2024
| @@ -6,6 +6,9 @@ jobs: | |||
| package-size: | |||
| name: Check package sizes | |||
| runs-on: ubuntu-latest | |||
| env: | |||
There was a problem hiding this comment.
Had to add this in. It was previously using the token in the nx.json but now had to use env variable
nkrantz
approved these changes
Aug 22, 2024
krisantrobus
added
🚀 merge it!
and removed
Status: Do Not Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the static NX token. It was a read only token for an open source project but flagged by internal security.
The token was deleted from NX Cloud and another one is shared in team 1Password if needed for local development.
The token has been updated in GitHub variables and you can see it correctly connecting for this PR 4042:
