Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nav): docs site navigation #4083

Merged
merged 4 commits into from
Sep 26, 2024
Merged

fix(nav): docs site navigation #4083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db7ea9a
fix(mobile-nav): horizontal scroll issue on header
PixeledCode Sep 20, 2024
d64b595
feat(mobile-nav): update mobile paste logo
PixeledCode Sep 20, 2024
59af1d3
feat(mobile-nav): fix build issue
PixeledCode Sep 20, 2024
5761553
feat(mobile-nav): update search bar height
PixeledCode Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 1 addition & 24 deletions packages/paste-website/src/components/site-wrapper/site-header/SiteHeaderLogo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import * as React from "react";

import { event } from "../../../lib/gtag";
import { PasteIcon } from "../../icons/PasteIcon";
import { PasteIconPride } from "../../icons/PasteIconPride";

const LogoLink = styled(Link)`
position: relative;
Expand Down Expand Up @@ -37,10 +36,6 @@ interface SiteHeaderLogoProps {
*/
const SiteHeaderLogo: React.FC<React.PropsWithChildren<SiteHeaderLogoProps>> = ({ title, subtitle }) => {
const theme = useTheme();
const [logoOpacity, setLogoOpacity] = React.useState(1);
const [hoverOpacity, setHoverOpacity] = React.useState(0);
const logoTransition = "ease-out 350ms";

return (
<Box display="flex" alignItems="center" minWidth={subtitle ? "sizeSidebar" : "size0"}>
<LogoLink
Expand All @@ -52,28 +47,10 @@ const SiteHeaderLogo: React.FC<React.PropsWithChildren<SiteHeaderLogoProps>> = (
label: "Paste logo",
})
}
onMouseEnter={() => {
setLogoOpacity(0);
setHoverOpacity(1);
}}
onMouseLeave={() => {
setLogoOpacity(1);
setHoverOpacity(0);
}}
>
<MediaObject verticalAlign="center">
<MediaFigure spacing="space40">
<PasteIconPride display="block" size={42} transition={logoTransition} opacity={logoOpacity} />
<PasteIcon
color={theme.textColors.colorTextBrandHighlight}
opacity={hoverOpacity}
transition={logoTransition}
display="block"
position="absolute"
top="0"
left="0"
size={42}
/>
<PasteIcon color={theme.textColors.colorTextBrandHighlight} display="block" size={38} />
</MediaFigure>
<MediaBody>
<Text as="div" fontSize="fontSize40" lineHeight="lineHeight30" color="colorText">
Expand Down
19 changes: 13 additions & 6 deletions packages/paste-website/src/components/site-wrapper/site-header/SiteHeaderSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@ import { SearchIcon } from "@twilio-paste/icons/esm/SearchIcon";
import { InlineCode } from "@twilio-paste/inline-code";
import { ScreenReaderOnly } from "@twilio-paste/screen-reader-only";
import { Text } from "@twilio-paste/text";
import { useWindowSize } from "@twilio-paste/utils";
import * as React from "react";
import { useHotkeys } from "react-hotkeys-hook";

import { SiteSearch } from "../../site-search";

const SiteHeaderSearch: React.FC = () => {
const [isOpen, setIsOpen] = React.useState(false);
const { breakpointIndex } = useWindowSize();
Copy link
Contributor

@roxanagomez roxanagomez Sep 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Do you know if we have a minimum window size we optimize for? I'm testing at 320px and it breaks, I was only able to test on this screen size in the browser, in my mobile device is working well, and the issue is fixed.
Screenshot 2024-09-24 at 1 00 46 PM

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah so with current implementation, 340px is the lower limit


const onOpen = (): void => {
setIsOpen(true);
Expand All @@ -35,7 +37,8 @@ const SiteHeaderSearch: React.FC = () => {
paddingTop="space20"
borderStyle="solid"
boxShadow="shadowBorder"
minWidth="200px"
minWidth={breakpointIndex === 0 ? "150px" : "200px"}
minHeight="36px"
color="colorTextIcon"
variant="reset"
size="reset"
Expand All @@ -59,11 +62,15 @@ const SiteHeaderSearch: React.FC = () => {
Search
</Text>
</Box>
<Box as="span" aria-hidden="true">
<InlineCode>⌘</InlineCode>
<InlineCode>K</InlineCode>
</Box>
<ScreenReaderOnly>Keyboard shortcut: Command / Control K</ScreenReaderOnly>
{breakpointIndex === 0 ? null : (
<>
<Box as="span" aria-hidden="true">
<InlineCode>⌘</InlineCode>
<InlineCode>K</InlineCode>
</Box>
<ScreenReaderOnly>Keyboard shortcut: Command / Control K</ScreenReaderOnly>
</>
)}
</Box>
</Button>
<SiteSearch isOpen={isOpen} onDismiss={onClose} />
Expand Down
Loading