Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable cluster test #719

Merged
merged 1 commit into from
Feb 9, 2024
Merged

chore: disable cluster test #719

merged 1 commit into from
Feb 9, 2024

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Feb 9, 2024

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

shrutiburman
shrutiburman reviewed Feb 9, 2024
View reviewed changes
.github/workflows/test-and-deploy.yml
run: |
dotnet tool install --global dotnet-sonarscanner
make cover
# - name: Install SonarCloud scanner and run analysis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix not work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the TWILIO_ACCOUNT_SID has expired. That's why we hare disabling it

@sbansla sbansla merged commit b835d21 into main Feb 9, 2024
9 checks passed
@sbansla sbansla deleted the disable-cluster-test branch February 9, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrutiburman shrutiburman shrutiburman left review comments

@tiwarishubham635 tiwarishubham635 tiwarishubham635 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbansla @tiwarishubham635 @shrutiburman