[23966] Improve input error to provide reason of failure #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #203 +/- ##
======================================
Coverage ? 86.85%
Complexity ? 252
======================================
Files ? 44
Lines ? 1073
Branches ? 101
======================================
Hits ? 932
Misses ? 88
Partials ? 53
Flags with carried forward coverage won't be shown. Click here to find out more. |
ferazog
reviewed
Feb 10, 2022
| * @param message associated message of the exception. | ||
| */ | ||
| sealed class InputException(override val message: String) : Exception(message) | ||
| object ExpiredChallengeException : InputException("Expired challenge can not be updated") |
There was a problem hiding this comment.
should message be a string resource instead?
There was a problem hiding this comment.
We don't need localization for the message, the idea is to explain the reason to the developer.
ferazog
approved these changes
Feb 10, 2022
SergioFierro
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Commit message
Screenshot
Testing