Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backgrounding without active audio can crash #89

Closed
ceaglest opened this issue Mar 1, 2017 · 8 comments
Closed

Backgrounding without active audio can crash #89

ceaglest opened this issue Mar 1, 2017 · 8 comments
Assignees
Labels

Comments

@ceaglest
Copy link
Contributor

ceaglest commented Mar 1, 2017

This is a bug fix we are working on for our next 1.0.0-beta9 release.

Problem Description

Does not occur when CallKit is being used.

Alice connects to a Room with no other Participants, and without using CallKit. Next Alice presses the home button and/or turns off the screen causing the app to enter a deep background state. During this time, signaling and media connections are killed by the OS.

Upon returning from the background Alice's app often crashes, and a signaling connection to the Room is not re-established.

The problem does not occur if there is at least one other Participant in the Room and either Alice or the remote party are sharing audio.

@piyushtank
Copy link
Contributor

We are aiming to have this issue fixed in our next Video SDK release 1.0.0-beta9. I will update the ticket when it is released.

@ceaglest
Copy link
Contributor Author

ceaglest commented Mar 1, 2017

@ptankTwilio thanks, updated the description to be more accurate.

@mknippen
Copy link

mknippen commented Mar 2, 2017

+1. I have also seen this issue.

@piyushtank
Copy link
Contributor

We have just released 1.0.0-beta9 which has backgrounding fixes in it. Please try it out and let us know if you have any questions. See changelogs.

@ceaglest
Copy link
Contributor Author

ceaglest commented Mar 7, 2017

In 1.0.0-beta9 we close the signaling connection upon detecting this backgrounding scenario, and attempt to re-establish it upon entering the foreground. We also handle SIG_PIPE exceptions that may be thrown by media connections during the backgrounding process.

@theprojectabot
Copy link

@ceaglest is there an email list on when new versions of the beta are sent out? I havent found one yet. Only by following this github. (like now we are on beta 9)

@ceaglest
Copy link
Contributor Author

ceaglest commented Mar 9, 2017

@theprojectabot we are working on something, but don't have any info to share at the moment. For now following this repo is okay as we update it every time a release is made. You could also follow our internal spec repo (https://github.com/twilio/cocoapod-specs).

@ceaglest
Copy link
Contributor Author

ceaglest commented Mar 9, 2017

Closing this ticket as fixed in 1.0.0-beta9. Please re-open if you are still able to reproduce backgrounding related crashes.

@ceaglest ceaglest closed this as completed Mar 9, 2017
paynerc pushed a commit that referenced this issue Jun 12, 2019
paynerc pushed a commit that referenced this issue Jun 12, 2019
Revert "ISDK-1628: Added a data track example to our current quick start (#89)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants