Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CallKit QuickStart sample app improvements #56

Merged
merged 2 commits into from
Dec 27, 2016
Merged

CallKit QuickStart sample app improvements #56

merged 2 commits into from
Dec 27, 2016

Conversation

piyushtank
Copy link
Contributor

This PR has following changes -

  1. StartCall - Avoid updating call.
  2. Report Connected Call state to CallKit for outgoing call.
  3. Disconnect from the Room on providerDidReset callback.
  4. Following speakerbox's guidelines to configure audio session while simulating incoming call

@bobiechen-twilio
Copy link
Contributor

Overall the PR LGTM. Just a minor comment. 👍

@piyushtank
Copy link
Contributor Author

Thanks @bchen-twilio

@piyushtank piyushtank merged commit e75d458 into twilio:master Dec 27, 2016
@piyushtank piyushtank deleted the task/improve-callkit-sample-app branch December 27, 2016 23:57
@vidhyasri2106 vidhyasri2106 mentioned this pull request Jun 7, 2019
Closed
paynerc pushed a commit that referenced this pull request Jun 12, 2019
@piyushtank
TwilioVideo 1.0.0-beta11 (#56)
6785130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bobiechen-twilio bobiechen-twilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piyushtank @bobiechen-twilio