担当教員と授業場所の編集欄を追加 #571
Merged
担当教員と授業場所の編集欄を追加 #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayato24s
requested review from
HikaruEgashira and
KanadeNishizawa
as code owners
hayato24s
force-pushed
the
feature/add-editors
branch
from
2d83616
to
fed4a11
Compare
|
お疲れ様です！Storybook にも追加してもらい感謝です！ |
hayato24s
force-pushed
the
feature/add-editors
branch
from
fed4a11
to
853d480
Compare
HosokawaR
reviewed
Oct 15, 2022
HosokawaR
reviewed
Oct 15, 2022
| const newElements = [...props.elements]; | ||
| newElements.push(""); | ||
| emit("update:elements", newElements); | ||
| focus([`#text-field-single-line-${newElements.length - 1}`, "input"]); |
There was a problem hiding this comment.
フォーカスしてくれるの、とても便利ですね…！！ナイスです
hayato24s
force-pushed
the
feature/add-editors
branch
from
853d480
to
671e0d6
Compare
HosokawaR
reviewed
Oct 15, 2022
HosokawaR
approved these changes
Oct 17, 2022
HikaruEgashira
approved these changes
Oct 21, 2022
| <TextFieldSingleLine | ||
| v-for="(el, i) in elements" | ||
| :id="`text-field-single-line-${i}`" | ||
| :key="`${i}`" |
|
バグを見つけて下さりありがとうございます。 |
KanadeNishizawa
approved these changes
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
手動で授業を追加するページと授業を編集するページにおいて、担当教員と授業場所を編集できるようにしました。
また、storybookも適宜追加しました。
Resolves #503