Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redmine_oauth_controller.rb #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update redmine_oauth_controller.rb #13

wants to merge 1 commit into from

Conversation

prattmic
Copy link
Contributor

@prattmic prattmic commented Aug 3, 2014

for Redmine 2.5.x

@gotva
Copy link
Contributor

gotva commented Aug 3, 2014

👍 Thank you very much!

@xandercage please pay attention that starting from version 2.4 core code for account_pending has been changed:
version 2.3 and before without user
version 2.4 and version 2.5 with user.

I would like to say the plugin should be splitted to support different Redmine versions and this PR should be accepted for last versions (2.4, 2.5).

Not sure but maybe it solves #11

@prattmic
Copy link
Contributor Author

prattmic commented Aug 3, 2014

Is there a way to query the Redmine version? If so, we could just add a version check here and call the appropriate version of the function.

@gotva
Copy link
Contributor

gotva commented Aug 3, 2014

good point

Sorry I can't check it myself now, but I think it is possible.

Look at this and compare
2.3
2.4
2.5

Constants MAJOR, MINOR, TINY correspond to versions
for example current version for 2.5 is

    MAJOR = 2
    MINOR = 5
    TINY  = 2

it is 2.5.2

@gotva
Copy link
Contributor

gotva commented Aug 7, 2014

@xandercage this PR should be closed withut merging because another PR (#14) with supporting all Redmine versions were added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants