Quick fix for association field. #11

miguelpayet · 2015-01-03T02:17:10Z

A quick fix for language-processing for fields pulled in via association field. Tested only in one site and one section (that is, basically untested).

Look at non-language fields to see if they contain item element and put them through processEntries function.
Add a parameter to processFields function.

Apparently my editor screwed up the spacing in a bunch of lines I didn't touch. The changes are in 256 & 272 and then starting from 336.

…f they contain item element and put them through processEntries function

miguelpayet · 2015-01-03T02:17:43Z

Jens: feel free not to merge this. Thanks for this extension, BTW.

jensscherbl · 2015-01-03T09:50:08Z

Thanks, will have a look at this.

twiro · 2017-02-15T10:08:10Z

This fix is a great help if you're combining multilingual and association field/output.

I have used this code in production on at least 4 different projects for about a year now and it seems to work stable and reliable - so I think it would be a good move to finally release it.

@jensscherbl - I just started working on some updates for this extension, but read on the forum that you're not planning to use/support it anymore. Which is sad as I really like the approach to multilingual you built here and think it's extemely useful especially for smaller multilingual projects (for which the "other" way of doing multilingual always seemed like a huge overkill to me).

If you really want to get rid of it I'd gladly take over ownership and take care about putting out new releases and possibly also extending the readme a little bit (information about frontend language detection and what this extension does and doesn't do regarding routing/urls would be super helpful... I know I struggled quite a little bit with this part when first working with the extension and most irritation reported in the forum seems to derive from these aspects too).

But If you changed your mind and are planning to keep this extension I'd gladly help updating it, explain/discuss my recent changes with you and send PRs for change that looks good to you.

Just let me know & thanks a lot for the great work!

twiro

Hey Miguel,

I just adopted the "multilingual"-repo from Jens and would merge your PR after you made some little tweaks (see my comments) and resubmit the PR against integration-branch!

Thanks for your work and let me know if you're not interested - then I'll simply apply theses changes myself.

Kind regards, Roman

twiro · 2017-02-28T11:49:48Z

extension.driver.php

@@ -305,38 +305,44 @@ private function processFields(XMLElement $xml)
            foreach ($elements as $element_index => $element) {

                // get element handle
+                if (is_object($element)) {


Could you change this line for this:

if ($element instanceof XMLElement) {

like used in the findEntries() function above?

twiro · 2017-02-28T11:50:19Z

extension.driver.php

+                           $xml->removeChildAt($element_index);
+                    }
+                    } else {
+                       $test = $element->getChildrenByName('item');


This line should be removed

twiro · 2017-02-28T11:50:56Z

extension.driver.php

                    }
                }
-            }
+				}


Indenting need to be fixed.

twiro · 2017-02-28T11:53:08Z

extension.driver.php

@@ -253,7 +253,7 @@ public function dataSourcePostExecute($context)

    // datasource output entries

-    private function findEntries(XMLElement $xml)
+    private function findEntries(XMLElement $xml, $entries_name = 'entry')


I think a variable named $node_name would make more sense than $entries_name as we're trying to process both entry- and item-nodes. Could you change this?

twiro · 2017-02-28T11:53:45Z

extension.driver.php

@@ -269,7 +269,7 @@ private function findEntries(XMLElement $xml)

                    // check if element is entry

-                    if ($element->getName() === 'entry') {
+                    if ($element->getName() === $entries_name) {


should then be $node_name too...

miguelpayet · 2017-02-28T12:02:28Z

Hi Roman, of course I'll make the changes and resubmit the PR. Thanks. Miguel El 28 feb. 2017, a las 06:58, Roman Klein <[email protected]> escribió: @twiro requested changes on this pull request. Hey Miguel, I just adopted the "multilingual"-repo from Jens and would merge your PR after you made some little teaks (see my comments) and resubmit the PR against integration-branch! Thanks for your work and let me know if you're not interested - then I'll simply apply theses changes myself. Kind regards, Roman In extension.driver.php:

@@ -305,38 +305,44 @@ private function processFields(XMLElement $xml)

foreach ($elements as $element_index => $element) { // get element handle + if (is_object($element)) { Could you change this line for this: if ($element instanceof XMLElement) { like used in the findEntries() function above? In extension.driver.php:

- // remove element - - $xml->removeChildAt($element_index); + $xml->removeChildAt($element_index); + } + } else { + $test = $element->getChildrenByName('item'); This line should be removed In extension.driver.php:

}

} - } + } Indenting need to be fixed. In extension.driver.php:

@@ -253,7 +253,7 @@ public function dataSourcePostExecute($context)

// datasource output entries - private function findEntries(XMLElement $xml) + private function findEntries(XMLElement $xml, $entries_name = 'entry') I think a variable named $node_name would make more sense than $entries_name as we're trying to process both entry- and item-nodes. Could you change this? In extension.driver.php:

@@ -269,7 +269,7 @@ private function findEntries(XMLElement $xml)

// check if element is entry - if ($element->getName() === 'entry') { + if ($element->getName() === $entries_name) { should then be $node_name too... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

twiro · 2017-03-03T08:59:41Z

Hi Roman, of course I'll make the changes and resubmit the PR. Thanks.

Thanks, Miguel! Do you think you can submit the changes in the next few days? Would love to get version 1.2 out as soon as possible to focus on the upcoming 2.0 update.

miguelpayet · 2017-03-03T15:12:31Z

i'll do it today. apologies for the delay. El 3 mar. 2017, a las 03:59, Roman Klein <[email protected]> escribió: Hi Roman, of course I'll make the changes and resubmit the PR. Thanks. Thanks, Miguel! Do you think you can submit the changes in the next few days? Would love to get version 1.2 out as soon as possible to focus on the upcoming 2.0 update. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

twiro · 2017-03-03T15:46:54Z

Great - Thank you! And no need to apologize...

miguelpayet · 2017-03-03T22:13:51Z

Hi Roman, I updated the code as you suggested & pushed the changes to my fork of the repo. This PR is now showing the updated code.

twiro · 2017-03-04T08:54:58Z

Thank you Miguel - I mergerd your PR and released version 1.2.0!

Quick fix for association field. Look at non-language fields to see i…

57db38b

…f they contain item element and put them through processEntries function

Fix for not processing nodes that are not children

2fe0a5d

twiro requested changes Feb 28, 2017

View reviewed changes

twiro self-assigned this Feb 28, 2017

twiro added this to the 1.2.0 milestone Feb 28, 2017

twiro mentioned this pull request Feb 28, 2017

Doesn't work for associated items (Subsection Manager / Association Field) #7

Closed

Enable working with association field

42e5c57

twiro merged commit e370d16 into twiro:master Mar 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quick fix for association field. #11

Quick fix for association field. #11

miguelpayet commented Jan 3, 2015

miguelpayet commented Jan 3, 2015

jensscherbl commented Jan 3, 2015

twiro commented Feb 15, 2017

twiro left a comment •

edited

Loading

twiro Feb 28, 2017

twiro Feb 28, 2017

twiro Feb 28, 2017

twiro Feb 28, 2017

twiro Feb 28, 2017

miguelpayet commented Feb 28, 2017 via email

twiro commented Mar 3, 2017

miguelpayet commented Mar 3, 2017 via email

twiro commented Mar 3, 2017

miguelpayet commented Mar 3, 2017

twiro commented Mar 4, 2017

Quick fix for association field. #11

Quick fix for association field. #11

Conversation

miguelpayet commented Jan 3, 2015

miguelpayet commented Jan 3, 2015

jensscherbl commented Jan 3, 2015

twiro commented Feb 15, 2017

twiro left a comment • edited Loading

Choose a reason for hiding this comment

twiro Feb 28, 2017

Choose a reason for hiding this comment

twiro Feb 28, 2017

Choose a reason for hiding this comment

twiro Feb 28, 2017

Choose a reason for hiding this comment

twiro Feb 28, 2017

Choose a reason for hiding this comment

twiro Feb 28, 2017

Choose a reason for hiding this comment

miguelpayet commented Feb 28, 2017 via email

twiro commented Mar 3, 2017

miguelpayet commented Mar 3, 2017 via email

twiro commented Mar 3, 2017

miguelpayet commented Mar 3, 2017

twiro commented Mar 4, 2017

twiro left a comment •

edited

Loading