build wheel only once per tox invocation #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Sep 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 74 74
Lines 10417 10420 +3
Branches 1071 1071
=======================================
+ Hits 9754 9757 +3
Misses 544 544
Partials 119 119
Continue to review full report at Codecov.
|
graingert
force-pushed
the
build-wheel-only-once
branch
2 times, most recently
from
a90cbcc
to
ce0abbb
Compare
graingert
changed the title
graingert
force-pushed
the
build-wheel-only-once
branch
from
ce0abbb
to
0440ad1
Compare
|
@adiroiban I think there's a race between the travis codecov upload and the github codecov upload |
graingert
commented
Sep 23, 2020
| @@ -28,7 +28,8 @@ envlist = | |||
|
|
|||
| [testenv] | |||
| wheel = True | |||
| wheel_pep571 = True | |||
| wheel_pep517 = True | |||
There was a problem hiding this comment.
a nasty typo: https://www.python.org/dev/peps/pep-0571/
when making a directory innaccessable, the TestCase.mktmp can't remove that directory and the directory cannot be copied into an isolated location for isolated builds ``` �[0K$ tox -e publishcov �[1mbuild create: /home/travis/build/twisted/ldaptor/.tox/build �[0m�[1mbuild installdeps: coverage >= 5.3, pyparsing, passlib, six �[0m�[1mbuild wheel-make: cleaning up build directory ... �[0m�[1mbuild wheel-make: commands[0] | pip wheel /home/travis/build/twisted/ldaptor --no-deps --use-pep517 --wheel-dir /home/travis/build/twisted/ldaptor/.tox/dist �[0m�[33mDEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support�[0m Processing /home/travis/build/twisted/ldaptor �[31mERROR: Exception: Traceback (most recent call last): File "/home/travis/build/twisted/ldaptor/.tox/build/lib/python2.7/site-packages/pip/_internal/cli/base_command.py", line 216, in _main status = self.run(options, args) File "/home/travis/build/twisted/ldaptor/.tox/build/lib/python2.7/site-packages/pip/_internal/cli/req_command.py", line 182, in wrapper return func(self, options, args) File "/home/travis/build/twisted/ldaptor/.tox/build/lib/python2.7/site-packages/pip/_internal/commands/wheel.py", line 156, in run reqs, check_supported_wheels=True File "/home/travis/build/twisted/ldaptor/.tox/build/lib/python2.7/site-packages/pip/_internal/resolution/legacy/resolver.py", line 183, in resolve discovered_reqs.extend(self._resolve_one(requirement_set, req)) File "/home/travis/build/twisted/ldaptor/.tox/build/lib/python2.7/site-packages/pip/_internal/resolution/legacy/resolver.py", line 388, in _resolve_one abstract_dist = self._get_abstract_dist_for(req_to_install) File "/home/travis/build/twisted/ldaptor/.tox/build/lib/python2.7/site-packages/pip/_internal/resolution/legacy/resolver.py", line 340, in _get_abstract_dist_for abstract_dist = self.preparer.prepare_linked_requirement(req) File "/home/travis/build/twisted/ldaptor/.tox/build/lib/python2.7/site-packages/pip/_internal/operations/prepare.py", line 469, in prepare_linked_requirement hashes=self._get_linked_req_hashes(req) File "/home/travis/build/twisted/ldaptor/.tox/build/lib/python2.7/site-packages/pip/_internal/operations/prepare.py", line 246, in unpack_url _copy_source_tree(link.file_path, location) File "/home/travis/build/twisted/ldaptor/.tox/build/lib/python2.7/site-packages/pip/_internal/operations/prepare.py", line 186, in _copy_source_tree shutil.copytree(source, target, **kwargs) File "/opt/python/2.7.15/lib/python2.7/shutil.py", line 222, in copytree raise Error, errors Error: [('/home/travis/build/twisted/ldaptor/_trial_temp/ldaptor.test.test_ldiftree/LDIFTreeEntryTests/test_children_noAccess_file/g7n75M/temp/dc=com.dir/dc=example.dir/ou=metasyntactic.dir/cn=foo.ldif', '/tmp/pip-req-build-w5KDMl/_trial_temp/ldaptor.test.test_ldiftree/LDIFTreeEntryTests/test_children_noAccess_file/g7n75M/temp/dc=com.dir/dc=example.dir/ou=metasyntactic.dir/cn=foo.ldif', "[Errno 13] Permission denied: '/home/travis/build/twisted/ldaptor/_trial_temp/ldaptor.test.test_ldiftree/LDIFTreeEntryTests/test_children_noAccess_file/g7n75M/temp/dc=com.dir/dc=example.dir/ou=metasyntactic.dir/cn=foo.ldif'"), ('/home/travis/build/twisted/ldaptor/_trial_temp/ldaptor.test.test_ldiftree/Dir2LDIF/testNoAccess/HwJxwi/temp/dc=com.dir/dc=example.dir/cn=foo.ldif', '/tmp/pip-req-build-w5KDMl/_trial_temp/ldaptor.test.test_ldiftree/Dir2LDIF/testNoAccess/HwJxwi/temp/dc=com.dir/dc=example.dir/cn=foo.ldif', "[Errno 13] Permission denied: '/home/travis/build/twisted/ldaptor/_trial_temp/ldaptor.test.test_ldiftree/Dir2LDIF/testNoAccess/HwJxwi/temp/dc=com.dir/dc=example.dir/cn=foo.ldif'")]�[0m �[31mERROR: InvocationError for command /home/travis/build/twisted/ldaptor/.tox/build/bin/pip wheel . --no-deps --use-pep517 --wheel-dir .tox/dist (exited with code 2) �[0m�[31mERROR: No distributions found in the dist directory found. Please check pyproject.toml, e.g with: pip wheel . --use-pep517 ```
ah it's not a race condition it's actually uncleaned up chmod calls! |
adiroiban
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a whl is built for each TOX_ENV, with this PR the whl will be created once before all other TOX_ENVs and reused
Contributor Checklist:
docs/source/NEWS.rstCONTRIBUTING.rst.