Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point the thrift id into NON_EXISTED_THRIFT_ID if the id resolver failed #115

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Point the thrift id into NON_EXISTED_THRIFT_ID if the id resolver failed #115

merged 1 commit into from
Oct 24, 2017

Conversation

Yaliang
Copy link
Collaborator

@Yaliang Yaliang commented Oct 17, 2017

No description provided.

@dabaitu
Copy link

dabaitu commented Oct 24, 2017

The purpose of this change is to yield better error msg?

@dabaitu dabaitu self-requested a review October 24, 2017 21:14
dabaitu
dabaitu approved these changes Oct 24, 2017
View reviewed changes
Copy link

@dabaitu dabaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to myself: whatever field not found will be null; helps with schema evolution

@Yaliang Yaliang merged commit 57be209 into twitter-forks:twitter-master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabaitu dabaitu dabaitu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yaliang @dabaitu