Add tests for QueryCompletedEventScriber and SlackBot #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaliang
changed the title
Yaliang
force-pushed
the
yaliangw/test-twitter-event-listener
branch
from
2b7ed5e
to
91079cd
Compare
|
Ready for reviewing |
luohao
reviewed
Nov 20, 2018
...stener-plugin/src/test/java/com/twitter/presto/plugin/eventlistener/slack/SlackResource.java
Outdated
Show resolved
Hide resolved
|
Ready for reviewing :) |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the thrift definition file into code base so that the Travis will run the tests.
Added tests for QueryCompletedEventScriber
Added tests for SlackBot