Case insensitive types #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2015 15:47
|
@syed72 This was a hack I had to put because even the "use column names" options was not case insensitive and failed if the column names had capital letters. And as is stated in the commit message, this is not complete. I only hacked on one read path for column names. There are many places which have string equality checks, and it would take some effort in truly making it case insensitive. In your case, the table name has capital letters. For that, I suggest changing the table name through hive's beeline. In fact, if your columns are all smalls, then you won't even need this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must revert it once Presto has case-insensitivity.