This repository has been archived by the owner on Nov 13, 2021. It is now read-only.
When plot = FALSE, don't call plot.new #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plot.new() is generally unfriendly to call unless it will actually be used for drawing, and certainly not if we ask for no plots to be created. plot.new triggers the completion of the previous plotting action, and as such can't be used in combination with any multithreading or forked R processes. plot.new also does not return a "plot" object, it always returns `NULL`, so although it appears to be used here as a way of returning a "null plot", all that really happens is that AnomalyDetection* returns `list(..., plot = NULL)`. This commit resolves twitter#60
|
Thanks @jcpetkovich ! |
|
@caniszczyk The PR looks good. Please merge. |
|
Anything holding this back from a merge? |
|
Ping! Just hit into this issue myself. |
|
Also just hit the issue. Does anyone else have write access to perform the merge? |
|
+1 to this change. I was about to do the same. |
|
/cc @caniszczyk |
|
+1 for this change - please let me know if I can help in any way to get this merged into the codebase. I'm hitting this issue when trying to run AnomalyDetectionTs in a subprocess. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plot.new() is generally unfriendly to call unless it will actually be
used for drawing, and certainly not if we ask for no plots to be
created.
plot.new triggers the completion of the previous plotting action, and as
such can't be used in combination with any multithreading or forked R
processes.
plot.new also does not return a "plot" object, it always returns
NULL,so although it appears to be used here as a way of returning a "null
plot", all that really happens is that AnomalyDetection* returns
list(..., plot = NULL).This commit resolves #60