Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] - When defaulting do not merge objects #276

Merged
merged 6 commits into from
Dec 18, 2018

Conversation

kaushlakers
Copy link
Contributor

Problem
When we set the config version 3 as default we broke v2 counting because we merge the passed in config with the default config. Now since emojiParsingEnabled is a new field, when we merge objects with the default config, it is always enabled

Solution
Don't merge configs. Only set to default it if we don't have anything in the config

Result
After the 3.0 release, v2 counting was broken. Now it will work again if it is explicitly passed.

Misc Changes:

  • Explicitly remove some files that were supposed to be deleted in the 3.0 commit. They stayed around because of the github merges missing files in your commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants