Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useful isValidHashtag() for java #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnlinp
Copy link

@johnlinp johnlinp commented Jan 8, 2019

Problem

The functions like isValidHashtag() in js and valid_hashtag() in ruby are useful, but there is no such function for java.

Solution

Add isValidHashtag() in Validator.java and add test cases in ValidatorTest.java.

Result

Java people can easily check if a text is a valid hashtag via isValidHashtag().

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2019

CLA assistant check
All committers have signed the CLA.

@andypiper
Copy link
Contributor

Passing to @leeaustinadams for review - thanks for the PR!

@johnlinp
Copy link
Author

Hi @leeaustinadams Any updates on this PR? Thanks!

@leeaustinadams
Copy link

Slowly orbiting back around to looking at twitter-text, will get you an update shortly.

Copy link

@leeaustinadams leeaustinadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than that one item (required for our internal lint rules)

java/src/main/java/com/twitter/twittertext/Validator.java Outdated Show resolved Hide resolved
The implementation references isValidHashtag() in js and valid_hashtag() in ruby
@johnlinp johnlinp force-pushed the add-is-valid-hashtag-for-java branch from c923cf9 to c5a2235 Compare February 16, 2019 03:14
@johnlinp
Copy link
Author

Hi @leeaustinadams I removed the redundant import line. Please take a look. Thank you.

@leeaustinadams
Copy link

Thanks! For this repo we need to merge it internally first and then push it back to github. Once that has happened I will close this pull request but you will be attributed in the commit message.

@johnlinp
Copy link
Author

johnlinp commented Apr 8, 2019

Hi @leeaustinadams Is there any updates on this PR?

@leeaustinadams
Copy link

I'm trying to find a time to distribute this internally as well since we need to do that in order to accept your change and push it back to GitHub. Thank you for your patience.

@johnlinp
Copy link
Author

johnlinp commented Aug 5, 2020

Hi @leeaustinadams and @andypiper,

I've signed the CLA, but the above check still shows "license/cla Pending — Contributor License Agreement is not signed yet." Do you have any idea why? Thanks.

@andypiper
Copy link
Contributor

I assume this repository is no longer maintained - I'm unable to help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants