Hide headers and footers when the dataset contains no suggestions #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The way we did this in the Twitter repo was a |
|
We're not using CSS anymore. |
|
Well, I should say we aren't using a stylesheet anymore. |
|
We could add that class and then let devs decide whether or not they want to hide the dataset – would still be the same amount of code though. |
|
Ahh right. Ship it. |
jharding
added a commit
that referenced
this pull request
Mar 13, 2013
…o-suggestions Hide headers and footers when the dataset contains no suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I probably should have included this in #81, it's the ideal behavior IMO.