Fix bad async suggestions rendering logic #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharding
added a commit
that referenced
this pull request
Apr 29, 2015
Fix bad async suggestions rendering logic
javiercejudo
referenced
this pull request
May 6, 2015
|
This fixes it. Thanks. |
|
#1212 also fixes but with tests ;) |
|
Same here :'( |
|
Same for us :) Spent also a few hours to find where the problem was. |
|
same here, look forward to merging into the master asap. |
|
Any idea when this is going into master ? |
|
ah i finally found why this is happening :D |
|
not working... forced to switch to fork #1212 |
cristian-sima
pushed a commit
to cristian-sima/Wisply
that referenced
this pull request
Oct 23, 2015
|
+1 for merge... |
|
Still not in master? How do I fix that and rebundle all files? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.