Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suggestion count #1773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix suggestion count #1773

wants to merge 1 commit into from

Conversation

willematcm
Copy link

Suggestions were lost when the number of suggestions dropped below the limit.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@emdadulsadik
Copy link

emdadulsadik commented Dec 10, 2019

@willematcm This seems to be a good patch, but have you considered other methods e.g. sync? Should you need to apply the patch for those methods as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants