Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset boolean on close function, this fixes #242 and #259 #260

Closed
wants to merge 1 commit into from

Conversation

stylenclass
Copy link
Contributor

  • I have added a false boolean on close function. Basically this boolean is responsible for closing the dropdown or not via closeUnlessMouseIsOverDropdown function.

- I have added a false boolean on close function. Basically this boolean is responsible for closing the dropdown or not via closeUnlessMouseIsOverDropdown function.
@houfeng0923
Copy link

yes, I solved this trouble in the say way . but I still don't know why the mouseleave event isn't triggered in chrome/firefox .
I feel very confused. :(

@stylenclass
Copy link
Contributor Author

@houfeng0707 its not that its not triggered, it is skipped! Say if you select an item it closes it, yet the boolean isMouseOverDropdown still remains true.

That's why I added a boolean reset when closed, that way that you are always sure it is false (which is the initial value). Whatever the scenario is.

Also this works at latest chrome and firefox. :). Just one line of code to fix 2 bugs

@houfeng0923
Copy link

hi, @stylenclass .
I guess the root cause of all is that mouseenter/leave event is simulated in chrome/firefox ,it is different with the native mouseenter/leave event in IE.

for example:
http://jsfiddle.net/houfeng0923/vw4hT/

@houfeng0923
Copy link

@stylenclass said right . Whatever the scenario is .

today I given up another scenario which made mouseleave event can trigger by itself ,
because it is not gracefull . I like sample things . :)

@jharding
Copy link
Contributor

Merged into integration-0.9.3. Thanks!

@jharding jharding closed this May 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants