Add support for a custom remotePreprocessor function & autodetect JSONP #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds remotesPreprocessor function which can process the response of a remote server call, in case the response is not in the correct format. The function takes the response as parameter and returns an array of strings or canonical datums. See https://github.com/twitter/typeahead.js#datums for more information
Compares the current location with the remote url to determine whether JSONP is required to communicate and sets the appropriate dataType for the $.ajax request
| //IE does not support location.origin, therefore we build it manuaully | ||
| var origin = [location.protocol,'//',location.host].join(''); | ||
|
|
||
| return new RegExp(origin).test(url) ? 'json' : 'jsonp'; |
There was a problem hiding this comment.
This doesn't allow CORS
|
Appreciate the pull request, but this overlaps with #25. If you have time, look over that pull request and post any feedback you may have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #8
Adds remotePreprocessor option to the Dataset specifications, which can process the response of a remote server call, in case the response is not in the correct format.
The function takes the response as a parameter and returns an array of
strings or canonical datums. See Datums for more information
Also compares window.location with the remote url to determine whether JSONP is required for a successful request and sets the appropriate dataType for the $.ajax
Updated the test suite & Readme.md