-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix and vital features Fork #575
Conversation
Lots and lots of changes (all for the better I hope)
Thanks for doing this. I apologize for my prolong absence, hopefully it won't happen again. Due to the nature of this pull request, I most likely won't merge it in, but I'll make sure the majority of your fixes make their way to the next official release of typeahead.js. |
Exellent 👍 |
New feature -Simplified initialization - suggestion search triggering (on demand) New feature - Busy indication
2 new featues added: JQuery Examples and Plunks ready |
@Svakinn once again, I can't thank you enough for the work you did. I really appreciate it. Now that v0.10.0 has been released, I wanted to circle back and touch upon the status of all of the issues mentioned in this PR:
Fixed!
Fixed!
How this works is now configurable based on the tokenizers provided.
I believe this should be resolved. You can now specify your own
Fixed!
Tracking at #550. Also there are 2 pending pull requests: #372 and #390. Both of those pull requests were against v0.9.3 so they need to be updated if one of them is to be accepted.
Seems like this covers a few issues:
All 3 of those issues should be resolved. For 1, that bug has been fixed. For 2, the caller now controls when the suggestion engine gets initialized. For 3, I cannot reproduce that behavior in v0.10.0, so I assume it's fixed.
Tracking at #166.
Not something that should be added to typeahead.js IMO. |
Hi there.
I would like to share with you a new fork with critical bug fixes and much requested features for typeahead.
Since the list of modifications is quite long I do not expect this pull to be accepted as is. The intention is more or less to supply a temporary solution for the control until the release of the next version. Also the code here could be useful for developers of the new version.
The short list of updates is here:
More detailed list of update is available here: https://github.com/Svakinn/typeahead.js/blob/typeaheadSimple/New.md
The new Readme.md is here: https://github.com/Svakinn/typeahead.js/blob/typeaheadSimple/README.md
RELATED ISSUES:
I took a quick look at open issues for the last 5 months and it seems that the changes in this fork, are related to or address the following issues:
Bugfix: IE11 problems
Function isMsie does not work in IE11 #557-nathankoop/Click on dropdown item misbehaves in IE #554-svakinn
Bugfix: Blur/Focus flickering
how to prevent AJAX requests when user selects an item #548-chrisdlangton, Clicking outside dropdown list doen't hide this dropdown #539-rtjm, Use the silent option when setting the input from a selection. #460-jaurand
Bugfix: Local data search
some result not shown dropdown #484-b4umel, how to search for any of token not all of them? #461-vinograd19
Custom data retrieval
Add an option to remote object called 'handler' to allow custom functions for remote #556-cusspvz, Using google maps autocomplete with typeahead js #536-harry2607, Missing callbacks / events for server communication started / stopped #518-dwt, Support local being a function #485-ansman, Added support of custom transport #473-speedblue
Keys & display names
Unique field? #547-narrowfail, add optional nameKey for input value display #546-ryanpitts, VALUE and OPTION like SELECT field #534-Venu85, Return custom display key instead of default value on Input selection. #523-jdaily, Support relational lookups #496-nikmartin, Add support for displaying duplicates, disable fetching suggestions after accepting a suggestion #481-davismj, Records with same value key #459-davidmturner
Caching control
A flag to prevent caching #562-krazyjakee, Store prefetch data source unique to the end-point #549-chrisdlangton, AJAX Post Calls #542-jasonterando, Add public method to clear all dataset requestCaches. #521-jgerigmeyer, Add refreshCache method and new event dropdownOpened. #515-tellex, local storage stores old data #501-PrimoZvanut, Many typeahead instances on one page are not working correctly. #492-jpbecotte, create cache clearing mechanism #476-dtudury, Remote dataset caches only on url #455-cusspvz
Selection verification
Passing through the fetched data to closed event triggering #566-zhigang1992, Added 'matched' and 'mismatched' custom events on blur #530-ambahk, Need to fire custom event when user types out a suggestion, but doesn't "select" or "autocomplete" #526-ahodges13, Adding force selection option to typeAhead (enhancement) #512-PetrSnobelt
Auto suggestion option
show all possible options on focus #550-netcult, Showing default suggestions on focus if minLength is 0 #390-theoephraim
Merry Christmas !!