Reduces dropdown flicker during a remote search. Fixes #176. #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behaviour of Bloodhound has been changed such that the #get callback is only run if matches in the search index (i.e. local or prefetched) have been found, or if we're not making a network request. The behaviour of Typeahead has been changed such that the dropdown is only cleared by the query changing if the query becomes an empty string.
|
|
||
| expect(this.dropdown.empty).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('should empty dropdown if the query is non-empty', function() { |
There was a problem hiding this comment.
should not empty dropdown menu, right?
|
Super excited to see this pull request. It seems like it makes sense and it should solve #176, but before merging this I want to do some testing myself. Will try and do that ASAP. |
Oops. :)
|
Played around with your pull request and it looks great! I see no reason why this shouldn't go out in v0.10.2. Thanks for your help! |
|
This landed in |
|
Yay, awesome! Thanks for merging 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is a little fix I threw together to address the flickering issue for the project I'm currently working on.
The behaviour of Bloodhound has been changed such that the #get callback is only run if matches in the search index (i.e. local or prefetched) have been found, or if we're not making a network request.
The behaviour of Typeahead has been changed such that the dropdown is only cleared by the query changing if the query becomes an empty string.
As we're not using any local or prefetched sources, this means that we no longer see flickering between network requests. Furthermore, if we were to use local or prefetched sources then any matches would be still immediately available. The result is that we only clear the dropdown when we know for sure that there are no matches.
I'm not sure if this is the sort of thing you had in mind, but thought it was worth sending over anyway.
Thanks for building typeahead.js - really nice little plugin. 😃