Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feed favicons #232

Open
twm opened this issue Apr 19, 2018 · 1 comment
Open

Feed favicons #232

twm opened this issue Apr 19, 2018 · 1 comment
Labels
enhancement

Comments

@twm
Copy link
Owner

twm commented Apr 19, 2018 •
edited
Loading

Harvest icon(s) for the feed from the linked site URL, or the first article's URL. Potential icon sources:

  • /favicon.ico
  • <link rel="icon">
  • Safari pinned tab icons
  • <link rel="apple-touch-icon"> (does anyone actually use this though?)
  • <link rel="apple-touch-icon-precomposed">
  • Web app manifest icons array

Yarrharr should compile a list of possible icons and allow the user to select one on the edit feed page.
@twm
Copy link
Owner Author

twm commented May 31, 2018

Some prior art: https://github.com/mat/besticon/

twm added a commit that referenced this issue Jun 17, 2018
@twm
ListArticle: Swipe left/right behaviors
0429054 
This also fixes the layout when an article is fave'd, though there is
still a bit of layout shift when it is toggled. I think that fixing that
can wait until favicons (#232), when the fave heart icon can move to
stick on the badge.

Closes #258.
@twm twm mentioned this issue Jun 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twm