Skip to content

Commit

Permalink
#7550 jagged spark status indicator heights (#7566)
Browse files Browse the repository at this point in the history
* #7550 style fixes

* #7550 fix lab
  • Loading branch information
piorek authored and scottdraves committed Jun 25, 2018
1 parent d72354e commit 3bc18f3
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 15 deletions.
2 changes: 1 addition & 1 deletion js/notebook/src/SparkUI.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export class SparkUIView extends widgets.VBoxView {
}

private updateSparkStatsStyles(): void {
this.sparkStats.node.style.marginRight = `${290 - (this.sparkStats.node.offsetWidth + this.connectionStatusElement.offsetWidth)}px`;
this.sparkStats.node.style.marginRight = `${294 - (this.sparkStats.node.offsetWidth + this.connectionStatusElement.offsetWidth)}px`;
}

private connectToApi() {
Expand Down
29 changes: 15 additions & 14 deletions js/notebook/src/shared/style/spark.scss
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,15 @@
.bx-stats {
margin: 4px 0;
height: 20px;
line-height: 17px;

.label {
font-weight: normal;
}
}

.bx-status-panel {
padding: 2px 0;
font-size: 14px;
.bx-button {
height: 24px;
padding: 0 6px;
Expand All @@ -159,11 +163,12 @@
.bx-connection-status {
background-color: transparent;
border: 1px solid $bxBorderColor1;
height: 20px !important;
line-height: 20px !important;
padding: 0 1em;
border-radius: 3px;
margin: 4px 6px;
height: 17px !important;
padding: .3em .6em;
border-radius: .25em;
margin: 4px !important;
font-size: 75% !important;
line-height: 1 !important;

&.connected {
border: none;
Expand Down Expand Up @@ -227,19 +232,15 @@
max-height: 24px;
vertical-align: middle;
float: right;
font-size: 14px;
line-height: 16px;

.bx-status-panel > .p-Widget {
margin-top: 2px;
}

.bx-connection-status {
height: 18px !important;
}

.bx-stats {
line-height: 14px;
margin-right: 5px!important;
}
.bx-connection-status {
margin-top: 2px !important;
}
}

Expand Down

0 comments on commit 3bc18f3

Please sign in to comment.