#6703 fixed setting list length on easyforms (#6710)

* #6703 single selection list size bug fix * #6703 python default EF list size set to options count
twosigma · Jan 24, 2018 · c59fed6 · c59fed6
1 parent 1fdfd96
commit c59fed6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/beakerx/beakerx/easyform/easyform.py b/beakerx/beakerx/easyform/easyform.py
@@ -80,7 +80,7 @@ def addList(self, *args, **kwargs):
             list = SelectMultipleSingle(
                 description=self.getDescription(args, kwargs))
         list.options = self.getOptions(args, kwargs)
-        list.size = getValue(kwargs, 'rows', 2)
+        list.size = getValue(kwargs, 'rows', len(list.options))
 
         self.children += (list,)
         self.components[list.description] = list

diff --git a/js/notebook/src/easyForm/selectMultipleSingleWidget.js b/js/notebook/src/easyForm/selectMultipleSingleWidget.js
@@ -33,13 +33,13 @@ var SelectMultipleSingleModel = widgets.SelectModel.extend({
 var SelectMultipleSingleView = widgets.SelectView.extend({
   update: function() {
     SelectMultipleSingleView.__super__.update.apply(this);
-    var items = this.model.get('_options_labels');
-    if (items && items.length !== undefined) {
-      $(this.listbox).attr('size', items.length);
-      $(this.el)
-        .removeClass('widget-select')
-        .addClass('widget-select-multiple');
+    var size = this.model.get('size');
+    if (size !== undefined) {
+      $(this.listbox).attr('size', size);
     }
+    $(this.el)
+    .removeClass('widget-select')
+    .addClass('widget-select-multiple');
   }
 });