#6638 fixed table display type conversion #6650
Conversation
| @@ -121,7 +121,9 @@ def convert_from_pandas(self, args, types_map): | |||
|
|
|||
| @staticmethod | |||
| def convert_value(value, value_type): | |||
| if value_type == "time": | |||
| if value == "": | |||
There was a problem hiding this comment.
I'm curious if a falsy test would be helpful here. The current code checks specifically for value being an empty string, but if the check was if value: we would catch None, an empty list, and other falsy values too.
Not sure if that's desirable, but certainly worth mentioning.
There was a problem hiding this comment.
empty list should appear as [].
none sounds right though, what does it do now?
There was a problem hiding this comment.
In the context of this function, it seems we return "string" for anything that doesn't match the specific checks. If we want to return "string" even when value is None, then the current code is all good. If we want to do something else when the value is None, we could do this at the at the end of the function.
Again, I'm not sure what the ideal behavior is, but I see a potentially unhandled case.
if value:
return "string"
raise Exception("Unknown value type")
No description provided.