This repository has been archived by the owner on Mar 22, 2023. It is now read-only.
avoids clearing TE headers while sending requests to the backend #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TE should only be removed for HTTP/2. See discussion envoyproxy/envoy#5541 |
shamsimam
force-pushed
the
handle-te-trailers
branch
2 times, most recently
from
f0eb1cc
to
45113c1
Compare
shamsimam
force-pushed
the
handle-te-trailers
branch
from
45113c1
to
f44502e
Compare
@sradack done, ready for review. |
sradack
approved these changes
Apr 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Why are we making these changes?
The te header is not removed as it is needed by grpc to detect incompatible proxies: https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md