fix: fix missing waypoint ancenstor prop & refine constant declaration

twreporter · Nov 8, 2022 · cd520f2 · cd520f2
1 parent c6f726e
commit cd520f2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/dual-channel/src/app/components/text/index.js b/packages/dual-channel/src/app/components/text/index.js
@@ -11,6 +11,7 @@ import React from 'react'
 import styled from 'styled-components'
 import { Waypoint } from 'react-waypoint'
 import { connect } from 'react-redux'
+import { scrollableAncestor } from '../../constants/customized-props'
 
 const _ = {
   get,
@@ -110,6 +111,7 @@ class ArticleText extends React.Component {
     const _renderSection = (section, sectionIndex) => {
       const sectionJsx = (
         <Waypoint
+          scrollableAncestor={scrollableAncestor}
           key={section.id}
           id={section.id}
           topOffset="49%"

diff --git a/packages/dual-channel/src/app/constants/customized-props.js b/packages/dual-channel/src/app/constants/customized-props.js
@@ -1,12 +1,12 @@
 const isClientSide =
   typeof window !== 'undefined' && typeof window.document !== 'undefined'
 
-let scrollableAncestorValue =
+const scrollableAncestorValue =
   isClientSide &&
   document.currentScript.getAttribute('data-scrollable-ancestor')
 export const scrollableAncestor = scrollableAncestorValue || undefined
 
-let offsetTopValue =
+const offsetTopValue =
   isClientSide && document.currentScript.getAttribute('data-offset-top')
 export const offsetTop =
   offsetTopValue &&