Jason/enable interfaces #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
這個做法很讚耶 |
|
@fzhantw 麻煩用這個branch試試, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #138 #139, 新增scrollableAncestor/offsetTop options，讓使用者可以調整embed code
option設定方式：在最後一個script tag加入
data-scrollable-ancestordata-offset-top,ex:
<script type="text/javascript" crossorigin="" src="/dist/main.a93c58f44676c91d15a5.bundle.js" data-scrollable-ancestor="window" data-offset-top="70"></script>@nickhsine 我這樣改您覺得ok嗎? 還請幫忙建議, 謝謝!
cc @fzhantw