Fix memoization with Hash-like objects as parameters #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWayfer
force-pushed
the
fix_memoization_with_hash-like_objects
branch
from
f79a52a
to
9c35df4
Compare
tycooon
reviewed
Feb 8, 2020
AlexWayfer
force-pushed
the
fix_memoization_with_hash-like_objects
branch
from
9c35df4
to
fe1e661
Compare
After adding `**kwargs` due to warnings in Ruby 2.7, Hash-like parameters (with `#to_hash` method) convert to Hash while passed in dynamically created by Memery method. For example, instances of `Sequel::Model`. Found Ruby bug: https://bugs.ruby-lang.org/issues/14909 So, changes will be in Ruby 2.8. And for now we can: 1. Use `**(;{})` as the additional parameter at method call, what is ugly. 2. Define memoized methods with `eval` and exactly expected arguments, what is dangerous (eval is evil). 3. Suppress warnings about keyword arguments until here are no failing tests. First, I've chose the 3th. But then Jeremy Evans suggest to use `ruby2_keywords`. So, here we're! Additional line of code offensed RuboCop (method length), so I was forced to refactor method definition.
AlexWayfer
force-pushed
the
fix_memoization_with_hash-like_objects
branch
from
fe1e661
to
903be49
Compare
tycooon
approved these changes
Feb 10, 2020
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding
**kwargsdue to warnings in Ruby 2.7,Hash-like parameters (with
#to_hashmethod) convert to Hashwhile passed in dynamically created by Memery method.
For example, instances of
Sequel::Model.Found Ruby bug: https://bugs.ruby-lang.org/issues/14909
So, changes will be in Ruby 2.8.
And for now we can:
**(;{})as the additional parameter at method call, what is ugly.evaland exactly expected arguments,what is dangerous (eval is evil).
First, I've chose the 3th.
But then Jeremy Evans suggest to use
ruby2_keywords. So, here we're!Additional line of code offensed RuboCop (method length),
so I was forced to refactor method definition.