add more string.h functions
#139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyfkda
reviewed
Feb 24, 2024
libsrc/string/memccpy.c
Outdated
| void *memccpy(void *dst, const void *src, int c, size_t n) { | ||
| void *b = memchr(src, c, n); | ||
| if (b != NULL) | ||
| n = b - src; |
There was a problem hiding this comment.
This is my mistake, but the compiler should warn about subtraction between two void pointers.
(gcc -pedantic says error: arithmetic on pointers to void is a GNU extension [-Werror,-Wgnu-pointer-arith])
Could you cast these pointers to char* before subtraction?
libsrc/string/strerror.c
Outdated
| }; | ||
|
|
||
| char *strerror(int no) { | ||
| if (no < 0 || no > sizeof(strerrors) / sizeof(*strerrors)) |
libsrc/string/strcpy.c
Outdated
| ; | ||
| return os; | ||
| stpcpy(dst, src); | ||
| return dst; | ||
| } |
There was a problem hiding this comment.
Could you leave this function unchanged?
Because I think stpcpy is more minor.
libsrc/string/strncpy.c
Outdated
| ; | ||
| return os; | ||
| stpncpy(dst, src, n); | ||
| return dst; | ||
| } |
There was a problem hiding this comment.
Could you leave this function unchanged?
ghost
force-pushed
the
more-string-functions
branch
from
2446fab
to
231b119
Compare
|
Thank you for the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven’t tested them thoroughly, but at least
strtokseems to be working fine.I want to work on more libc functions later, but I figured I should start with something simple to begin with!
If you find any mistakes, please let me know, and I can correct them!