-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No internal display after disconnecting external displays #69
Comments
@Chivs for my acpi-patches: #28 (comment) |
Does the machine wakeup by opening the lid when not connected to an external monitor without pressing an additional key or similar? I just checked your usecase and it's working for me as expected. As I said, it depends on the _PRW-config in ACPI which is patched in this repo. Working original config for LID-Device:
|
Please let me know if you manage to use BT devices to wake the PC. I am also using it in clamshell mode, but after putting the computer to sleep I must:
Needless to say this is a pain, and involves the displays rearranging/changing resolution several times. I used to suffer from the black screen at wake problem, but some changes to the config by tylernguyen fixed it for me - albeit with HDMI. Not sure maybe it has to do with the TB3 running as a displayport vs. just USB C ? |
@Porco-Rosso What mode of sleep are you talking about? And by TB3 you are talking about DisplayPort over USB-C, right? TB3 is a complete different topic and we shouldn't mix up. Also I have no TB3-Devices to test, so I can't help with that. Blackscreens on HDMI where a bug on KabyLake-Framebuffers in Catalina with WhateverGreen afaik. In Github those bugs should be resolved, but they never occured to me in the first place. |
@benbender Sorry, not that knowledgable about the USBC/TB spec. I assumed that displayport (4k etc) would be carried over TB3, but it seems you have corrected me; it is over USB C. I believe it is a regular sleep state:
As for my HDMI situation (not in the office to test with usb-c display) It works, but upon wake does not seem to detect the display. I need to unplug it and replug it in to re-discover. Simply waking does not power on or wake the display. |
@Porco-Rosso Nope - its "DisplayPort over USB-C"[1] and has nothing to do with Thunderbolt or its controller in the thinkpad |
Here it is:
|
Let's sort a bit:
|
Correction, my internal display is indeed turning on with the lid opening. I am just not getting the external display to connect without a replug on the HDMI. As a separate issue, using a usbc-to-HDMI dock also fails to detect the resolutions available. Sorry to detract, I thought there might be some overlap but that does not seem to be the case. I will wait for this issue to be resolved and will raise my inconveniences later. Like I mentioned, I used to have the same issue as @Chivs but the latest EFI resolved these issues. Maybe clearing NVRAM might help? |
Yes, wakeup via LID is fine. The exact repo steps are as follows:
@Porco-Rosso issue via HDMI is a separate issue which I also experienced. Single monitor connected by HDMI will not wake up after lid open. |
Please test the following config. It:
Report back afterwards. In case of further problems, pls paste a recent "pmset -g log"-output beginning with the according "sleep"-event until the full wake incl. display and the output of "log show --last boot|grep -i kbl" to see what the framebuffer is doing. |
@Chivs @Porco-Rosso Do you have the appropriate internal display EDID override installed? See At least your HDMI replug issue is related to that @Porco-Rosso |
@tylernguyen this is more like a mitigation afaik. The underlying bug should be this one in WEG: acidanthera/WhateverGreen@677b486 |
Yeah, I'm thinking that it is up to WEG developers also. Meanwhile, if applying an EDID override still does not fix this issue, @Chivs @Porco-Rosso , you guys should try testing: |
;) |
Yes, I have the EDID override, will doublecheck but will try the iGPU tests you are suggesting as well |
Ok, so I ran some tests using your config and ACPI files. Couple of points first,
Using the updated config, here's what I found.
|
Hey, I would try the following:
Additionally test the following framebuffer-config:
From your logs FB0 (internal display) is waking up. So lets eliminate stuff that could interfere and try a more modern framebuffer. |
Ok, so followed these steps:
Tried three times now and display is waking up properly. I am finding a couple of other quirks, which may be unavoidable.
BTW Thanks for all this assistance, really appreciated. |
Just to be sure: use "pmset restoredefaults" to reset your pm-settings. Just to clearify: What resolution does your external monitor use? If 4k, which method/patches are you using? When you refer to sleep/wake up, we are now talking about hibernatemode 3/S3 with pulsating power-light, right?
Might be a cached edid. Check if it can be changed with https://github.com/avibrazil/RDM.
BT on mac is connected on mac via UART afaik. I'm not sure if its even possible. Pls check if you can wake up the device via usb (mouse/keyboard f.e.)
Sharing is caring ;) EDIT: just checked about the method for the LED used in this repo and noticed I didn't checked before - just use https://github.com/tylernguyen/x1c6-hackintosh/blob/master/patches/SSDT-LED.dsl from the repo without any renames and delete my SSDT-TTS. Sorry about that! |
Done
Both monitors are 4k, enabled via DVMT prealloc in BIOS
May be my mistake as the media dongle is HDMI 1.4 which I believe limits to 30Hz
Good question. No, a USB mouse plugged in does not wake the laptop. |
Crosscheck on another machine/OS.
try the following: https://osy.gitbook.io/hac-mini-guide/details/usb-fix / https://github.com/osy86/USBWakeFixup |
@Chivs @Porco-Rosso Just add it on the my latest EFI folder and let me know if that resolves the issue. |
Gave it a try with @benbender updated DeviceProperties but it's a no go. |
@Chivs That's weird. I just tried it and it worked for me. Do you have the 4k fix enabled? |
Nope, have 4k by the DVMT-prealloc in BIOS. I just tried by disconnecting external monitors before waking with lid and it worked, so it seems unreliable so far. |
Try it with a clean copy of my latest EFI. Don't forget to add EDID override. |
The latest commit, a598de6 should resolve this issue. |
@tylernguyen Complete modeset is enforced for KabyLake-Framebuffers anyway. See https://github.com/acidanthera/WhateverGreen/blob/1.4.1/WhateverGreen/kern_igfx.cpp#L107. I've recently changed my framebuffer to 591C0005 and tested every scenario here with success:
|
@benbender would you mind posting your OC folder/config. This has still been plaguing me together with sleep/wake unreliability. Additionally, are you also using the one-key-hidpi ? |
Sure. Be aware that this is from a T480 (extremly similar to X1C6) but you'll need at least a different EDID. I'm also using macbookpro14,2 as a platform, because of the similarity of the hardware. Besides that, the system tries to mimic a genuine macbook while keeping the patches clean & minimal. Kexts are latest stable and left out for size (0C 0.6, WEG 1.4.1). Most stuff is really hotkeys and battery-patching. My system also has the patched bios. |
Thanks @benbender, I've created a new config based on your setup and getting decent results. Still some more testing to do as I've also flashed TB and switched to BIOS Assist disabled and getting around 1.00 PKG on battery. Promising so far. |
When using the laptop with lid closed connected to two 4k monitors via Thunderbolt/USB-C, if you disconnect the external monitors in a grab-and-go fashion, opening the lid does not re-enable the internal display requiring a hard shutdown and reboot.
The text was updated successfully, but these errors were encountered: