Skip to content
This repository has been archived by the owner on Jul 6, 2018. It is now read-only.

Add typings for ember-inflector #23

Merged
merged 3 commits into from
Sep 4, 2017
Merged

Add typings for ember-inflector #23

merged 3 commits into from
Sep 4, 2017

Conversation

dwickern
Copy link
Collaborator

Then we can pull it out from ember-data

@dwickern
Copy link
Collaborator Author

@chriskrycho I just noticed you have a PR at emberjs/ember-inflector#132

@chriskrycho
Copy link
Member

chriskrycho commented Aug 28, 2017

Yeah, though I think it's been lost in the shuffle. Two notes:

  1. I don't know what all is desired to be treated as public API for Inflector. cc. @locks @rwjblue on that.
  2. It seems iffy to me whether we should merge those bits into the ember namespace. Obviously that represents what's actually happening, so perhaps we should do it to support good backwards compatibility—but on the other hand we have a good opportunity here to push more toward the new modules API, and per the last core team meeting notes, they really want TS stuff that gets into Ember.js itself only to support the modules API.

@dwickern
Copy link
Collaborator Author

The tests were pulled from official guides and docs so I consider those to be public API. I might have grabbed some private Inflector methods though

I would like to support backwards compatibility to a reasonable extent. If we want to remove public APIs it should go through the official deprecation process and the typings will follow suit. It's going to be hard enough to convert a project from JS to TS without API changes.

@chriskrycho
Copy link
Member

That seems like a reasonable stance to me.

@dwickern
Copy link
Collaborator Author

dwickern commented Sep 4, 2017

The next step is to pull these inflector APIs out of the ember-data typings.

@dwickern dwickern merged commit 80bb135 into master Sep 4, 2017
@dwickern dwickern deleted the ember-inflector branch September 4, 2017 00:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants