Support custom extensions with allowImportingTsExtensions
#621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| `); | ||
| }); | ||
|
|
||
| test.runIf(semver.gte(typescript.version, '5.0.0'))( |
There was a problem hiding this comment.
this is a cool util! test.runIf!
NullVoxPopuli
approved these changes
Sep 24, 2023
|
Also, I tried this branch of glint against the project we are trying to convert to a v2 addon, which contains imports with |
|
Should be available in |
|
thanks! Already PR'd an update here: embroider-build/addon-blueprint#206 |
|
Things are moving fast, it's awesome 👏 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to the one taken in #620, and fixes #618.
#620 attempts to support import paths with an explicit
.gtsextension by rewriting those imports during transformation, but module resolution really shouldn't be a concern of the transform layer. For example:.gtsextensions #618 in a way that works correctly even in files that we aren't transforming at all (consider that vanilla.tsfiles might import from.gtsfiles).gtsfiles without the extension)TS has a hard-coded internal set of the extensions it considers to "be" TypeScript, and we work around this fact by presenting custom extensions like
.gjsand.gtsas.jsand.tsfiles respectively. This is how such files get included during whole-project typechecking, and is also how extensionless imports of.gtsand.gjsare resolved today.This PR addresses #618 in the same manner as we handle custom extensions in general: by providing a custom hook for the compiler API to implement the behavior we want. In this instance, the hook is
resolveModuleNameLiteralsrather than the system-levelreadFileand friends, but the gist is the same: when a.gtsfile is imported, we intercept and rewrite the request to as though it had been for the corresponding.tsfile.