Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GlimmerX #716

Merged
merged 16 commits into from
Mar 21, 2024
Merged

Remove GlimmerX #716

merged 16 commits into from
Mar 21, 2024

Conversation

machty
Copy link
Contributor

@machty machty commented Mar 19, 2024

emberjs/rfcs#1014

Removes any reference of GlimmerX from Glint.

Justification from the RFC:

most people don't even know what GlimmerX is, it's not under active development, it doesn't play nicely with our plans to use TS Plugins. Therefore, we should remove it from Glint before proceeding further with the proposals in this RFC.

Notes

  • It seems that a lot of the ideas that wound up in ember-template-imports (i.e. <template> tags within .gts files) were first tested out via inline hbs template tags in the glimmerx environment; in order to not lose test coverage, I did my best to convert these glimmerx test to .gts ember-template-import tests rather than wholesale removing them.

@machty machty marked this pull request as ready for review March 20, 2024 02:29
@NullVoxPopuli NullVoxPopuli added the breaking A breaking change label Mar 20, 2024
@NullVoxPopuli
Copy link
Contributor

Before merge, we should probably release the current stuff on main

@wagenet wagenet merged commit ee54032 into typed-ember:main Mar 21, 2024
6 checks passed
@machty machty deleted the rm-glimmerx branch March 22, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants