Add .bazelrc containing RBE config #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haikalpribadi
pushed a commit
that referenced
this pull request
Jun 25, 2022
## What is the goal of this PR?
Previously, if a TypeQL string contained a syntax error, and also had a trailing newline, an unhelpful error was thrown: `Index 1 out of bounds for length 1`. This was due to a bug in the error handler.
Now, a more helpful error is reported, for instance:
```
There is a syntax error at line 1:
match $x isa thing
^
no viable alternative at input 'match $x isa thing'
```
## What are the changes implemented in this PR?
Suppose we are parsing the following query:
```typeql
match $x isa thing
```
It includes a trailing newline.
Previously, we were attempting to parse the raw unmodified query string. The parser scans to the end of the query string and reports that there is a syntax error on line 2:
```
[TQL03] TypeQL Error: There is a syntax error at line 2:
^
no viable alternative at input 'match $x isa thing\n'
```
Firstly, this is still not a great error - it shows us that the "syntax error" is on a completely empty line.
Secondly, our error handler itself throws an error while trying to handle this error. In the error handler we convert the query string to a `List<String` using `String.split("\n")` with no `limit` parameter, which means that if the final character is a newline, we end up with less lines than we started with; in the example above, we have a 2-line query but only 1 entry in our String list.
We then print out a line from our string list that matches the line number where the error was reported, and boom, we get our `ArrayIndexOutOfBoundsException`.
We _could_ fix it by using `String.split("\n", -1)` which preserves all lines, even if they are blank; but, while that intuitively feels like the more "correct" fix, in practice, the resulting error is much nicer if we actually strip out the trailing newline. So we now use `trim` to strip out all leading and trailing whitespace, which should be intuitive enough for users.
(One thing to consider: should we strip only **trailing** whitespace?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
To enable RBE for faster tests. Closes #1.
What are the changes implemented in this PR?
.bazelrcfile. You can then invoke Bazel with RBE like so:bazel ... --config=rbe.BAZEL_RBE_CREDENTIAL. The environment variable is set not from the code but from the CircleCI setting for the Graql repository.