Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong type hints for SyndicationFeed methods #1705

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix wrong type hints for SyndicationFeed methods #1705

merged 1 commit into from
Sep 12, 2023

Commits on Sep 12, 2023

  1. Fix wrong type hints for SyndicationFeed methods 

    Django's documentation mentions that the handler is of type
xml.sax.saxutils.XMLGenerator. However, it is actually of type
django.utils.xmlutils.SimplerXMLGenerator, which is a subclass of the
former.

Methods like `addQuickElement` (which are used in django's own
implementation of add_root_elements) is actually defined for
SimplerXMLGenerator, so this seems like the best fit, given that
subclasses will commonly rely on this method.
    @WhyNotHugo
    WhyNotHugo committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    489f218 View commit details
    Browse the repository at this point in the history