-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0: Update django.forms.formsets
#2145
Conversation
Btw, why there's no stubtest change? |
I've checked on that issue but I couldn't find it. Is there anything I'm missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, fix them:
django-stubs/scripts/stubtest/allowlist_todo.txt
Lines 1296 to 1298 in 6ff16d9
django.forms.BaseFormSet.__init__ | |
django.forms.BaseFormSet.deletion_widget | |
django.forms.BaseFormSet.ordering_widget |
I attempted to modify the error: django.forms.BaseFormSet.__init__ is inconsistent,
runtime argument "error_class" has a default value of type abc.ABCMeta,
which is incompatible with stub argument type type[django.forms.utils.ErrorList] error_class: ABCMeta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's keep __init__
ignored for now. It is a complex problem.
Since ErrorList
extends UserList
which extends collections.abc.MutableMapping
.
I have made things!
Update stubs for
django.forms.formsets
for Django 5.0.django.forms.formsets
django.forms.formsets.BaseFormSet.form_renderer
was addeddjango.forms.formsets.BaseFormSet.renderer
was addedRelated issues
Refs
Upstream PR