Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate 'test_conf.yml' to 'assert_type' tests #2182

Merged
merged 3 commits into from
May 25, 2024

Conversation

flaeppe
Copy link
Member

@flaeppe flaeppe commented May 24, 2024

I tried to get started on moving .yml tests to assert_type style tests. Also tried to adjust the cases to fit the assert_type style a little bit better.

Let me know what you think.

@flaeppe flaeppe requested review from intgr and sobolevn May 24, 2024 21:08
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes look good! Thanks! One question

django-stubs/urls/conf.pyi Outdated Show resolved Hide resolved
@flaeppe flaeppe merged commit 95e7d4d into typeddjango:master May 25, 2024
36 checks passed
@flaeppe flaeppe deleted the fix/migrate-test-conf branch May 27, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants