Allow any function for admin's display and action decorators
#2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realised that: - The `display` decorator isn't limited to any specific type of callable, it accepts anything really. - The `action` decorator was trying to dictate a callable type that the `ModelAdmin.actions` expects. But that's the responsibility of `ModelAdmin`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that:
displaydecorator isn't limited to any specific type of callable, it accepts anything really.actiondecorator was trying to dictate a callable type that theModelAdmin.actionsexpects. But that's the responsibility ofModelAdmin. Andactionalso accepts anything.Refs:
Selfis possible to use for actions -- ref: Improve ModelAdmin and decorator hints and attributes, add tests #1292 (comment)