Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check annotated fields in <QuerySet>.filter call #2332

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Check annotated fields in <QuerySet>.filter call #2332

merged 1 commit into from
Aug 9, 2024

Conversation

flaeppe
Copy link
Member

@flaeppe flaeppe commented Aug 9, 2024

sobolevn
sobolevn approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@flaeppe flaeppe merged commit e7611b3 into typeddjango:master Aug 9, 2024
36 checks passed
@flaeppe flaeppe deleted the fix/annotate-with-filter branch August 9, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.filter with wrong fields does not fail if .annotate is used
2 participants
@flaeppe @sobolevn