Allow lookups on .annotate
fields
#2376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow lookups on fields coming from
.annotate()
Django does not object when fields introduced via
QuerySet.annotate
are used in.filter
with lookup chains:mypy
, however, rejects this with a really cryptic error message:Since now all
.annotate
fields are resolved as plainAny
, I think it's fair to allow chaining any lookups with them. This PR does exactly that: when aid2__something
lookup is encountered andid2
is not a model field, proceed with checking thatid2
is.annotate
field and accept if so, ignoring the chained lookups.