This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
Improve the performance of Map's algebras. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed an issue in cats-kernel where operations over Maps were incredibly slow. This commit ports those fixes over here, where our additive/multiplicative monoids experienced the same issues.
Merged
| else if (n == 0) zero | ||
| else throw new IllegalArgumentException("Illegal negative exponent to sumN: %s" format n) | ||
|
|
||
| override def sum(as: TraversableOnce[Map[K, V]]): Map[K, V] = { |
There was a problem hiding this comment.
we don't have trySum here:
can we do the same override on AdditiveMonoid or here so that trySum calls sum?
|
minor comment about |
This mirrors a similar change in cats-kernel. The basic idea is that if someone goes to the trouble of writing an optimized .sum method we'd like for .trySum to use it as well.
| if (xs.size <= ys.size) { | ||
| timesMap(xs, ys)((x, y) => V.times(x, y)) | ||
| xs.foldLeft(Map.empty[K, V]) { case (m, (k, x)) => |
There was a problem hiding this comment.
I wonder if Map.empty makes sense here or if we should use the mutable approach? Like, we could allocate an empty MMap about the size of the smallest entry (an upperbound).
I think this will be faster, if we care, but we can come back to it later if you prefer.
There was a problem hiding this comment.
Let's do this now, and then make that change with a benchmark later.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed an issue in cats-kernel where operations over Maps were
incredibly slow. This commit ports those fixes over here, where our
additive/multiplicative monoids experienced the same issues.
Review by @johnynek